Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(azuread-oidc): allow personal accounts #5540

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

fabius
Copy link
Contributor

@fabius fabius commented Mar 26, 2023

Definition of Ready

Edit tasklist title
Beta Give feedback Tasklist Definition of Ready, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I am happy with the code
    Options
  2. Short description of the feature/issue is added in the pr description
    Options
  3. PR is linked to the corresponding user story
    Options
  4. Acceptance criteria are met
    Options
  5. All open todos and follow ups are defined in a new ticket and justified
    Options
  6. Deviations from the acceptance criteria and design are agreed with the PO and documented.
    Options
  7. No debug or dead code
    Options
  8. Critical parts are tested automatically
    Options
  9. Where possible E2E tests are implemented
    Options
  10. Documentation/examples are up-to-date
    Options
  11. All non-functional requirements are met
    Options
  12. Functionality of the acceptance criteria is checked manually on the dev system.
    Options

There's no user story for this. Trying to sign up using a company Azure account works fine with the default configuration. Personal accounts run into an error like

http status not ok: 403 Forbidden {"error":{"code":"ErrorInsufficientPermissionsInAccessToken","message":"Exception of type 'Microsoft.Fast.Profile.Core.Exception.ProfileAccessDeniedException' was thrown.","innerError":{"date":"...,"request-id":"...","client-request-id":"..."}}}

Setting the User.Read scope explicitly grants the necessary privileges.

@vercel
Copy link

vercel bot commented Mar 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 7:05am

@hifabienne hifabienne changed the title doc(azuread-oidc): allow personal accounts docs(azuread-oidc): allow personal accounts Apr 12, 2023
@hifabienne hifabienne merged commit 080a44b into zitadel:main Apr 12, 2023
2 checks passed
@hifabienne
Copy link
Member

Hei @fabius
Thanks for your contribution.
Please reach out to hi@zitadel.com if you like to get some swag from us. 😃

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants