Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventstore): order by creation_date and sequence #5568

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

adlerhurst
Copy link
Member

@adlerhurst adlerhurst commented Mar 29, 2023

closes #5302

Definition of Ready

Edit tasklist title
Beta Give feedback Tasklist Definition of Ready, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I am happy with the code
    Options
  2. Short description of the feature/issue is added in the pr description
    Options
  3. PR is linked to the corresponding user story
    Options
  4. Acceptance criteria are met
    Options
  5. All open todos and follow ups are defined in a new ticket and justified
    Options
  6. Deviations from the acceptance criteria and design are agreed with the PO and documented.
    Options
  7. No debug or dead code
    Options
  8. Critical parts are tested automatically
    Options
  9. Where possible E2E tests are implemented
    Options
  10. Documentation/examples are up-to-date
    Options
  11. All non-functional requirements are met
    Options
  12. Functionality of the acceptance criteria is checked manually on the dev system.
    Options

@adlerhurst adlerhurst self-assigned this Mar 29, 2023
@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 9:18am

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #5568 (65ce38d) into main (991a563) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5568   +/-   ##
=======================================
  Coverage   48.42%   48.42%           
=======================================
  Files         693      693           
  Lines       72237    72238    +1     
=======================================
+ Hits        34981    34982    +1     
  Misses      35620    35620           
  Partials     1636     1636           
Impacted Files Coverage Δ
internal/eventstore/repository/sql/crdb.go 62.01% <100.00%> (ø)
...nal/eventstore/v1/internal/repository/sql/query.go 87.19% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@livio-a livio-a merged commit 4c1169b into main Apr 5, 2023
6 checks passed
@livio-a livio-a deleted the event-ordering branch April 5, 2023 09:34
mffap pushed a commit that referenced this pull request Apr 6, 2023
* feat(eventstore): order by `creation_date` and `sequence`

* fix(logstore): use correct event type

---------

Co-authored-by: Livio Spring <livio.a@gmail.com>
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eventstore filters events sorted by creation date AND sequence
2 participants