Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saml): correct handling of remove #5606

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

adlerhurst
Copy link
Member

fixes the following panic:

runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xf79054]
at github.com/zitadel/zitadel/internal/command.removeAppIDFromEntityIDs ( [/home/runner/work/zitadel/zitadel/internal/command/project_application_saml_model.go:261](https://console.cloud.google.com/debug?referrer=fromlog&file=%2Fhome%2Frunner%2Fwork%2Fzitadel%2Fzitadel%2Finternal%2Fcommand%2Fproject_application_saml_model.go&line=261&project=zitadel-domains) )

Tasks

@adlerhurst adlerhurst requested a review from livio-a April 4, 2023 14:45
@adlerhurst adlerhurst self-assigned this Apr 4, 2023
@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 11:28am

@adlerhurst adlerhurst enabled auto-merge (squash) April 4, 2023 14:45
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #5606 (82a0e88) into main (991a563) will increase coverage by 0.00%.
The diff coverage is 93.10%.

@@           Coverage Diff           @@
##             main    #5606   +/-   ##
=======================================
  Coverage   48.42%   48.42%           
=======================================
  Files         693      693           
  Lines       72237    72239    +2     
=======================================
+ Hits        34981    34984    +3     
+ Misses      35620    35619    -1     
  Partials     1636     1636           
Impacted Files Coverage Δ
internal/command/project_application_saml_model.go 61.79% <0.00%> (+0.34%) ⬆️
internal/eventstore/repository/sql/crdb.go 62.01% <100.00%> (ø)
...nal/eventstore/v1/internal/repository/sql/query.go 87.19% <100.00%> (+0.07%) ⬆️
internal/query/projection/idp_login_policy_link.go 58.68% <100.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adlerhurst adlerhurst merged commit d981f0d into main Apr 5, 2023
6 checks passed
@adlerhurst adlerhurst deleted the fix(saml)--correct-handling-of-remove branch April 5, 2023 11:42
mffap pushed a commit that referenced this pull request Apr 6, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants