Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): refine onboarding styles and behavior, i18n #5616

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

peintnermax
Copy link
Member

Partial of #5566

Tasks

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 11:47am

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #5616 (cdb7f26) into main (991a563) will decrease coverage by 0.01%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main    #5616      +/-   ##
==========================================
- Coverage   48.42%   48.41%   -0.01%     
==========================================
  Files         693      693              
  Lines       72237    72253      +16     
==========================================
+ Hits        34981    34982       +1     
- Misses      35620    35632      +12     
- Partials     1636     1639       +3     
Impacted Files Coverage Δ
internal/command/project_application_saml_model.go 61.79% <0.00%> (+0.34%) ⬆️
internal/query/event.go 0.00% <0.00%> (ø)
internal/query/org.go 44.44% <0.00%> (-0.20%) ⬇️
...epository/eventsourcing/eventstore/auth_request.go 24.17% <31.57%> (-0.33%) ⬇️
internal/eventstore/repository/sql/crdb.go 62.01% <100.00%> (ø)
...nal/eventstore/v1/internal/repository/sql/query.go 87.19% <100.00%> (+0.07%) ⬆️
internal/query/projection/idp_login_policy_link.go 58.68% <100.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's e2e test the onboarding view.
Please also check the DoR boxes.

@peintnermax
Copy link
Member Author

Let's e2e test the onboarding view. Please also check the DoR boxes.

what exactly do you want to test?

Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about this? #5617

@eliobischof
Copy link
Member

I aggree, writing good e2e tests for the onboarding is a lot easier when #5618 is merged.

@juergrinaldi
Copy link
Contributor

@peintnermax @eliobischof Do you have a ETA when the PR is through for me to review? (as there's a blogpost for @dakshitha dependent on this). Thanks. 😃

@eliobischof
Copy link
Member

what do you think about this? #5617

The rest looks good to me

@eliobischof
Copy link
Member

@peintnermax @eliobischof Do you have a ETA when the PR is through for me to review? (as there's a blogpost for @dakshitha dependent on this). Thanks. smiley

Do you need it ASAP? Then I can deploy it to our dev environment.

@juergrinaldi
Copy link
Contributor

@peintnermax @eliobischof Do you have a ETA when the PR is through for me to review? (as there's a blogpost for @dakshitha dependent on this). Thanks. smiley

Do you need it ASAP? Then I can deploy it to our dev environment.

Yes please. 👍 As @dakshitha wants to publish the blogpost today and I need to change the screenshots.

@peintnermax
Copy link
Member Author

what do you think about this? #5617

I think we have to discuss this a little further as some events wont show up again.. I would address this seperately as it has nothing to do with the onboarding or does it? the events are filtered anyways 🤔

* fix(onboarding): only human events

* explicitly exclude system api events

---------

Co-authored-by: Max Peintner <max@caos.ch>
@eliobischof eliobischof enabled auto-merge (squash) April 6, 2023 11:38
@eliobischof eliobischof merged commit 2ee7b9c into main Apr 6, 2023
5 of 6 checks passed
@eliobischof eliobischof deleted the cnsl-onbrdng-optm branch April 6, 2023 12:02
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants