-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(console): refine onboarding styles and behavior, i18n #5616
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #5616 +/- ##
==========================================
- Coverage 48.42% 48.41% -0.01%
==========================================
Files 693 693
Lines 72237 72253 +16
==========================================
+ Hits 34981 34982 +1
- Misses 35620 35632 +12
- Partials 1636 1639 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's e2e test the onboarding view.
Please also check the DoR boxes.
what exactly do you want to test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about this? #5617
I aggree, writing good e2e tests for the onboarding is a lot easier when #5618 is merged. |
@peintnermax @eliobischof Do you have a ETA when the PR is through for me to review? (as there's a blogpost for @dakshitha dependent on this). Thanks. 😃 |
The rest looks good to me |
Do you need it ASAP? Then I can deploy it to our dev environment. |
Yes please. 👍 As @dakshitha wants to publish the blogpost today and I need to change the screenshots. |
I think we have to discuss this a little further as some events wont show up again.. I would address this seperately as it has nothing to do with the onboarding or does it? the events are filtered anyways 🤔 |
* fix(onboarding): only human events * explicitly exclude system api events --------- Co-authored-by: Max Peintner <max@caos.ch>
🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Partial of #5566
Tasks