Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(console): remove first and lastName fallback from user #5629

Merged
merged 8 commits into from
Apr 11, 2023

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Apr 6, 2023

Partial #5344

Tasks

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 3:56pm

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #5629 (52637d0) into main (991a563) will decrease coverage by 0.02%.
The diff coverage is 46.00%.

@@            Coverage Diff             @@
##             main    #5629      +/-   ##
==========================================
- Coverage   48.42%   48.40%   -0.02%     
==========================================
  Files         693      693              
  Lines       72237    72359     +122     
==========================================
+ Hits        34981    35028      +47     
- Misses      35620    35691      +71     
- Partials     1636     1640       +4     
Impacted Files Coverage Δ
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/server.go 0.00% <0.00%> (ø)
...i/grpc/management/project_application_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/server.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 3.84% <0.00%> (-5.53%) ⬇️
.../api/grpc/server/middleware/service_interceptor.go 0.00% <0.00%> (ø)
internal/api/grpc/server/server.go 0.00% <0.00%> (ø)
internal/api/grpc/system/server.go 0.00% <0.00%> (ø)
internal/command/project_application_saml_model.go 61.79% <0.00%> (+0.34%) ⬆️
internal/command/user_human_otp.go 27.89% <ø> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@livio-a livio-a enabled auto-merge (squash) April 11, 2023 15:10
@livio-a livio-a merged commit 1c1d66c into main Apr 11, 2023
4 of 6 checks passed
@livio-a livio-a deleted the cnsl-displayname branch April 11, 2023 15:56
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use displayname instead of first and lastname
3 participants