Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): LDAP UI optimization for better required field recognition, improve onboarding all done visibility #5659

Merged
merged 13 commits into from
Apr 18, 2023

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Apr 11, 2023

Partial of #5654

  • Improves component to add multiple entries for servers, user bindings
  • Improves visibility of the first and only required mapping field such that its clear that it needs to be filled to complete the form,
  • adds a visibility fix for the onboarding view if all cards are completed,

Bildschirm­foto 2023-04-11 um 16 28 07

Bildschirm­foto 2023-04-18 um 16 30 23

Tasks

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 3:00pm

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #5659 (b9787ba) into main (991a563) will increase coverage by 0.00%.
The diff coverage is 52.94%.

@@           Coverage Diff            @@
##             main    #5659    +/-   ##
========================================
  Coverage   48.42%   48.43%            
========================================
  Files         693      693            
  Lines       72237    72406   +169     
========================================
+ Hits        34981    35067    +86     
- Misses      35620    35697    +77     
- Partials     1636     1642     +6     
Impacted Files Coverage Δ
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/server.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp_converter.go 9.39% <0.00%> (-0.06%) ⬇️
...i/grpc/management/project_application_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/server.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 3.84% <0.00%> (-5.53%) ⬇️
.../api/grpc/server/middleware/service_interceptor.go 0.00% <0.00%> (ø)
internal/api/grpc/server/server.go 0.00% <0.00%> (ø)
internal/api/grpc/system/server.go 0.00% <0.00%> (ø)
internal/command/project_application_saml_model.go 61.79% <0.00%> (+0.34%) ⬆️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adlerhurst
Copy link
Member

all tough I filled all the required fields I'm aware of the create button is disabled: ZITADEL • Console.pdf

Copy link
Member

@adlerhurst adlerhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tough I filled all the required fields I'm aware of the create button is disabled: ZITADEL • Console.pdf

@adlerhurst
Copy link
Member

all tough I filled all the required fields I'm aware of the create button is disabled: ZITADEL • Console.pdf

ah pressing the plus helped. I think this behaves different than on the create app pages

@adlerhurst adlerhurst merged commit c420de1 into main Apr 18, 2023
8 checks passed
@adlerhurst adlerhurst deleted the idp-fxs branch April 18, 2023 15:37
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants