Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable grpc server reflection #5689

Merged
merged 5 commits into from May 16, 2023
Merged

feat: enable grpc server reflection #5689

merged 5 commits into from May 16, 2023

Conversation

muhlemmer
Copy link
Contributor

@muhlemmer muhlemmer commented Apr 14, 2023

This change enables gRPC server reflection. It allows for easier setting up of dev-tools like gRPCurl and gRPCui.

To see it in action, after you start zitadel on the localhost:

go install github.com/fullstorydev/grpcui/cmd/grpcui@latest
grpcui -plaintext localhost:8080

image

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 8:58am

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #5689 (383e68b) into main (2962870) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #5689      +/-   ##
==========================================
+ Coverage   44.64%   44.66%   +0.01%     
==========================================
  Files        1186     1187       +1     
  Lines      104515   104527      +12     
==========================================
+ Hits        46665    46682      +17     
+ Misses      55676    55672       -4     
+ Partials     2174     2173       -1     
Impacted Files Coverage Δ
internal/api/grpc/probes.go 72.72% <72.72%> (ø)
internal/api/api.go 68.00% <100.00%> (+0.21%) ⬆️

... and 4 files with indirect coverage changes

@livio-a livio-a enabled auto-merge May 16, 2023 08:51
@livio-a livio-a merged commit e442738 into main May 16, 2023
10 checks passed
@livio-a livio-a deleted the grcp-server-reflect branch May 16, 2023 09:17
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants