Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user v2alpha email API #5708

Merged
merged 23 commits into from
Apr 25, 2023
Merged

feat: user v2alpha email API #5708

merged 23 commits into from
Apr 25, 2023

Conversation

adlerhurst
Copy link
Member

Tasks

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 6:02am

@adlerhurst adlerhurst linked an issue Apr 18, 2023 that may be closed by this pull request
6 tasks
@muhlemmer muhlemmer self-assigned this Apr 19, 2023
Not complete, was not able to mock the generator.
improve test coverage
including unit tests
@muhlemmer muhlemmer changed the title New email api feat: user v2alpha email API Apr 21, 2023
run gci on modified files
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #5708 (fa2f54a) into main (991a563) will decrease coverage by 0.06%.
The diff coverage is 59.60%.

@@            Coverage Diff             @@
##             main    #5708      +/-   ##
==========================================
- Coverage   48.42%   48.37%   -0.06%     
==========================================
  Files         693      713      +20     
  Lines       72237    73123     +886     
==========================================
+ Hits        34981    35372     +391     
- Misses      35620    36088     +468     
- Partials     1636     1663      +27     
Impacted Files Coverage Δ
internal/api/authz/authorization.go 65.38% <0.00%> (+11.70%) ⬆️
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/server.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp_converter.go 9.39% <0.00%> (-0.06%) ⬇️
...i/grpc/management/project_application_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/server.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 3.84% <0.00%> (-5.53%) ⬇️
.../api/grpc/server/middleware/service_interceptor.go 0.00% <0.00%> (ø)
internal/api/grpc/server/server.go 0.00% <0.00%> (ø)
internal/api/grpc/system/server.go 0.00% <0.00%> (ø)
... and 28 more

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@livio-a livio-a merged commit 095ec21 into main Apr 25, 2023
8 of 9 checks passed
@livio-a livio-a deleted the new-email-api branch April 25, 2023 07:02
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Create/Change/Verify Email
3 participants