-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: introduce measures to avoid bots crawling and indexing activities #5728
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #5728 +/- ##
=======================================
Coverage 44.40% 44.41%
=======================================
Files 1173 1175 +2
Lines 103086 103114 +28
=======================================
+ Hits 45778 45799 +21
- Misses 55159 55166 +7
Partials 2149 2149
|
Thanks @doncicuto |
IMHO we can disallow robots on our login page, but disabling it in our console would also make our other meta tags unnecessary which are used to render a preview in chats / social media or doesn't it? 🤔 |
Who do you ask this? 😃 |
The PR and console changes look good to me. Maybe @adlerhurst or @livio-a can review the golang code |
i'll try check in the afternoon or at latest tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the handler as well to the grpc-web handler here: https://github.com/doncicuto/zitadel/blob/6068796a436fba5699e39038d3c8922d27fb5437/internal/api/api.go#L176
Hi @adlerhurst, I've added the x-robots-tag to grpcwebserver as requested, thanks for the review |
hi @doncicuto Thanks for your contribution. 🙏🏻 |
🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Add robots.txt, robots meta tag and X-Robots-Tag to avoid bots crawling and indexing activities for a Zitadel instance
Acceptance Criteria
Here are some screenshots:
HTML source code
API Response Headers
Robots.txt found
Tasks