Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integration test base #5739

Merged
merged 19 commits into from
May 4, 2023
Merged

chore: integration test base #5739

merged 19 commits into from
May 4, 2023

Conversation

muhlemmer
Copy link
Contributor

@muhlemmer muhlemmer commented Apr 24, 2023

Add integrations tests for the gRPC API, primarily targeted at v2 but can also be used for legacy. Provides a crude framework that runs a server, prepares a client and exposes the underlying resources such as command and query handlers to the tester. The code in internal/integration is written just as a proof of concept and probably needs to be split up in more reusable chunks when we need more functionality, like multiple users, organisations, instances etc.

Integrations tests for user/v2alpha are also included.

See the added documentation for more details.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Related to #5598

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 7:16am

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #5739 (11f0f54) into main (991a563) will decrease coverage by 4.02%.
The diff coverage is 44.68%.

@@            Coverage Diff             @@
##             main    #5739      +/-   ##
==========================================
- Coverage   48.42%   44.40%   -4.02%     
==========================================
  Files         693     1173     +480     
  Lines       72237   103086   +30849     
==========================================
+ Hits        34981    45778   +10797     
- Misses      35620    55159   +19539     
- Partials     1636     2149     +513     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/config_change.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/auth/user_grant.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp_converter.go 9.39% <0.00%> (-0.06%) ⬇️
...i/grpc/management/project_application_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/member/converter.go 0.00% <0.00%> (ø)
... and 49 more

... and 630 files with indirect coverage changes

@muhlemmer muhlemmer marked this pull request as ready for review May 2, 2023 16:35
internal/integration/integration.go Outdated Show resolved Hide resolved
internal/integration/integration.go Outdated Show resolved Hide resolved
internal/integration/integration.go Show resolved Hide resolved
internal/integration/integration.go Show resolved Hide resolved
internal/integration/integration.go Outdated Show resolved Hide resolved
internal/integration/integration.go Show resolved Hide resolved
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants