-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integration test base #5739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 68200dc.
Codecov Report
@@ Coverage Diff @@
## main #5739 +/- ##
==========================================
- Coverage 48.42% 44.40% -4.02%
==========================================
Files 693 1173 +480
Lines 72237 103086 +30849
==========================================
+ Hits 34981 45778 +10797
- Misses 35620 55159 +19539
- Partials 1636 2149 +513
|
stebenz
reviewed
May 3, 2023
2 tasks
stebenz
approved these changes
May 3, 2023
4 tasks
4 tasks
4 tasks
🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integrations tests for the gRPC API, primarily targeted at
v2
but can also be used for legacy. Provides a crude framework that runs a server, prepares a client and exposes the underlying resources such ascommand
andquery
handlers to the tester. The code ininternal/integration
is written just as a proof of concept and probably needs to be split up in more reusable chunks when we need more functionality, like multiple users, organisations, instances etc.Integrations tests for
user/v2alpha
are also included.See the added documentation for more details.
Definition of Ready
Acceptance criteria are metDeviations from the acceptance criteria and design are agreed with the PO and documented.Functionality of the acceptance criteria is checked manually on the dev system.Related to #5598