Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add user creation to user service #5745

Merged
merged 39 commits into from
Apr 26, 2023
Merged

feat(api): add user creation to user service #5745

merged 39 commits into from
Apr 26, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Apr 25, 2023

closes #5017

Tasks

adlerhurst and others added 30 commits April 14, 2023 09:06
Not complete, was not able to mock the generator.
improve test coverage
including unit tests
run gci on modified files
# Conflicts:
#	internal/api/grpc/object/v2/converter.go
#	internal/repository/user/human_email.go
#	proto/zitadel/object/v2alpha/object.proto
#	proto/zitadel/user/v2alpha/email.proto
#	proto/zitadel/user/v2alpha/user_service.proto
# Conflicts:
#	internal/command/command.go
#	proto/zitadel/object/v2alpha/object.proto
#	proto/zitadel/user/v2alpha/email.proto
#	proto/zitadel/user/v2alpha/user_service.proto
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 5:25am

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #5745 (2f98ebc) into main (991a563) will decrease coverage by 0.11%.
The diff coverage is 49.26%.

@@            Coverage Diff             @@
##             main    #5745      +/-   ##
==========================================
- Coverage   48.42%   48.31%   -0.11%     
==========================================
  Files         693      716      +23     
  Lines       72237    73343    +1106     
==========================================
+ Hits        34981    35437     +456     
- Misses      35620    36234     +614     
- Partials     1636     1672      +36     
Impacted Files Coverage Δ
internal/api/authz/authorization.go 65.38% <0.00%> (+11.70%) ⬆️
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/server.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp_converter.go 9.39% <0.00%> (-0.06%) ⬇️
...i/grpc/management/project_application_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/server.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 3.84% <0.00%> (-5.53%) ⬇️
...nal/api/grpc/server/middleware/auth_interceptor.go 72.00% <0.00%> (-10.61%) ⬇️
.../api/grpc/server/middleware/service_interceptor.go 0.00% <0.00%> (ø)
... and 28 more

... and 39 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@livio-a livio-a merged commit e4a4b7c into main Apr 26, 2023
8 of 9 checks passed
@livio-a livio-a deleted the user-register branch April 26, 2023 05:47
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Register Username Password
3 participants