Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch log level of failed locks to debug #5746

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

eliobischof
Copy link
Member

Tasks

@eliobischof eliobischof self-assigned this Apr 25, 2023
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 4:47pm

@eliobischof
Copy link
Member Author

IMO, I'd rather delete the log lines, as the errors are already handled by returning them / sending them to a channel.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #5746 (99d7ff0) into main (991a563) will decrease coverage by 0.06%.
The diff coverage is 59.28%.

@@            Coverage Diff             @@
##             main    #5746      +/-   ##
==========================================
- Coverage   48.42%   48.37%   -0.06%     
==========================================
  Files         693      713      +20     
  Lines       72237    73123     +886     
==========================================
+ Hits        34981    35372     +391     
- Misses      35620    36088     +468     
- Partials     1636     1663      +27     
Impacted Files Coverage Δ
internal/api/authz/authorization.go 65.38% <0.00%> (+11.70%) ⬆️
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/server.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp_converter.go 9.39% <0.00%> (-0.06%) ⬇️
...i/grpc/management/project_application_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/server.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 3.84% <0.00%> (-5.53%) ⬇️
.../api/grpc/server/middleware/service_interceptor.go 0.00% <0.00%> (ø)
internal/api/grpc/server/server.go 0.00% <0.00%> (ø)
internal/api/grpc/system/server.go 0.00% <0.00%> (ø)
... and 26 more

... and 30 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eliobischof eliobischof merged commit c12c2f0 into main Apr 25, 2023
7 of 8 checks passed
@eliobischof eliobischof deleted the hide-initial-lock-failed branch April 25, 2023 17:21
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants