Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): device code #5771

Merged
merged 9 commits into from
May 11, 2023
Merged

feat(console): device code #5771

merged 9 commits into from
May 11, 2023

Conversation

peintnermax
Copy link
Member

Closes #5684

Tasks

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:46am

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #5771 (c472a16) into main (11f0f54) will increase coverage by 0.19%.
The diff coverage is 61.70%.

@@            Coverage Diff             @@
##             main    #5771      +/-   ##
==========================================
+ Coverage   44.40%   44.60%   +0.19%     
==========================================
  Files        1173     1181       +8     
  Lines      103086   104181    +1095     
==========================================
+ Hits        45778    46469     +691     
- Misses      55159    55542     +383     
- Partials     2149     2170      +21     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/config_change.go 0.00% <0.00%> (ø)
internal/api/http/header.go 12.00% <ø> (ø)
internal/api/http/middleware/auth_interceptor.go 12.19% <0.00%> (ø)
internal/api/ui/console/console.go 24.74% <0.00%> (-5.64%) ⬇️
internal/domain/permission.go 0.00% <ø> (ø)
internal/repository/session/aggregate.go 0.00% <0.00%> (ø)
internal/repository/session/session.go 0.00% <0.00%> (ø)
internal/api/http/middleware/access_interceptor.go 10.00% <15.62%> (-4.29%) ⬇️
internal/api/authz/token.go 44.89% <18.75%> (-6.30%) ⬇️
... and 24 more

... and 11 files with indirect coverage changes

Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to applications.cy.ts

@peintnermax peintnermax marked this pull request as draft May 11, 2023 06:31
@peintnermax
Copy link
Member Author

Please add a test to applications.cy.ts

E2E test for native, device code is added

@eliobischof eliobischof enabled auto-merge (squash) May 11, 2023 07:35
@eliobischof eliobischof merged commit 2dc016e into main May 11, 2023
10 checks passed
@eliobischof eliobischof deleted the cnsl-device-code branch May 11, 2023 08:18
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grant type device_code to console
3 participants