Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new protoc plugin for api v2 #5798

Merged
merged 6 commits into from
May 4, 2023
Merged

refactor: use new protoc plugin for api v2 #5798

merged 6 commits into from
May 4, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented May 3, 2023

Tasks

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 7:52am

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #5798 (315830f) into main (11f0f54) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main    #5798      +/-   ##
==========================================
- Coverage   44.40%   44.40%   -0.01%     
==========================================
  Files        1173     1173              
  Lines      103086   103093       +7     
==========================================
  Hits        45778    45778              
- Misses      55159    55166       +7     
  Partials     2149     2149              
Impacted Files Coverage Δ
internal/api/grpc/server/gateway.go 51.76% <0.00%> (-4.65%) ⬇️
...nal/api/grpc/server/middleware/auth_interceptor.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@livio-a livio-a requested a review from adlerhurst May 3, 2023 14:53
@livio-a livio-a marked this pull request as ready for review May 3, 2023 14:53
Copy link
Member

@adlerhurst adlerhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main is too complex

@livio-a livio-a merged commit f1534c0 into main May 4, 2023
8 of 10 checks passed
@livio-a livio-a deleted the protoc-zitadel branch May 4, 2023 08:50
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants