Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Helm charts from next #5815

Merged
merged 2 commits into from May 12, 2023
Merged

chore: bump Helm charts from next #5815

merged 2 commits into from May 12, 2023

Conversation

eliobischof
Copy link
Member

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@eliobischof eliobischof requested a review from livio-a May 10, 2023 16:43
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 4:38am

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #5815 (694cef4) into main (11f0f54) will increase coverage by 0.25%.
The diff coverage is 61.03%.

@@            Coverage Diff             @@
##             main    #5815      +/-   ##
==========================================
+ Coverage   44.40%   44.66%   +0.25%     
==========================================
  Files        1173     1185      +12     
  Lines      103086   104490    +1404     
==========================================
+ Hits        45778    46670     +892     
- Misses      55159    55649     +490     
- Partials     2149     2171      +22     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/config_change.go 0.00% <0.00%> (ø)
internal/api/grpc/settings/v2/settings.go 0.00% <0.00%> (ø)
internal/api/http/header.go 12.00% <ø> (ø)
internal/api/http/middleware/auth_interceptor.go 12.19% <0.00%> (ø)
internal/api/ui/console/console.go 24.74% <0.00%> (-5.64%) ⬇️
internal/api/ui/login/renderer.go 10.55% <0.00%> (-0.09%) ⬇️
internal/domain/permission.go 0.00% <ø> (ø)
internal/domain/policy_login.go 60.00% <0.00%> (+22.50%) ⬆️
internal/repository/session/aggregate.go 0.00% <0.00%> (ø)
... and 32 more

... and 6 files with indirect coverage changes

@livio-a livio-a enabled auto-merge (squash) May 12, 2023 04:32
@livio-a livio-a merged commit 240b799 into main May 12, 2023
10 checks passed
@livio-a livio-a deleted the bump-chart-versions branch May 12, 2023 05:06
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants