Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only reuse port for integration tests #5817

Merged
merged 2 commits into from
May 11, 2023
Merged

fix: only reuse port for integration tests #5817

merged 2 commits into from
May 11, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented May 11, 2023

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 8:35am

@livio-a livio-a requested a review from eliobischof May 11, 2023 08:33
@livio-a livio-a marked this pull request as ready for review May 11, 2023 08:33
@eliobischof eliobischof enabled auto-merge (squash) May 11, 2023 08:36
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #5817 (3d759c5) into main (11f0f54) will increase coverage by 3.88%.
The diff coverage is 56.22%.

❗ Current head 3d759c5 differs from pull request most recent head 5b7e44d. Consider uploading reports for the commit 5b7e44d to get more accurate results

@@            Coverage Diff             @@
##             main    #5817      +/-   ##
==========================================
+ Coverage   44.40%   48.29%   +3.88%     
==========================================
  Files        1173      729     -444     
  Lines      103086    74519   -28567     
==========================================
- Hits        45778    35986    -9792     
+ Misses      55159    36846   -18313     
+ Partials     2149     1687     -462     
Impacted Files Coverage Δ
internal/api/authz/authorization.go 65.38% <0.00%> (-26.93%) ⬇️
internal/api/authz/context.go 3.12% <0.00%> (-52.44%) ⬇️
internal/api/authz/permissions.go 71.42% <0.00%> (-4.07%) ⬇️
internal/api/authz/token.go 28.57% <0.00%> (-22.62%) ⬇️
internal/api/grpc/server/gateway.go 2.72% <0.00%> (-53.69%) ⬇️
internal/api/grpc/session/v2/server.go 0.00% <0.00%> (-100.00%) ⬇️
internal/api/grpc/user/v2/user.go 9.63% <0.00%> (-72.92%) ⬇️
internal/api/http/middleware/access_interceptor.go 0.00% <0.00%> (-14.29%) ⬇️
internal/api/http/middleware/auth_interceptor.go 0.00% <0.00%> (-12.20%) ⬇️
internal/command/command.go 16.66% <0.00%> (-70.66%) ⬇️
... and 14 more

... and 619 files with indirect coverage changes

@eliobischof eliobischof merged commit c07411e into main May 11, 2023
8 checks passed
@eliobischof eliobischof deleted the fix-listen branch May 11, 2023 08:58
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants