Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eventstore): add created_at column #5818

Merged
merged 6 commits into from May 16, 2023
Merged

fix(eventstore): add created_at column #5818

merged 6 commits into from May 16, 2023

Conversation

adlerhurst
Copy link
Member

@adlerhurst adlerhurst commented May 11, 2023

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 6:49am

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #5818 (2962870) into main (11f0f54) will increase coverage by 0.24%.
The diff coverage is 60.51%.

@@            Coverage Diff             @@
##             main    #5818      +/-   ##
==========================================
+ Coverage   44.40%   44.64%   +0.24%     
==========================================
  Files        1173     1186      +13     
  Lines      103086   104515    +1429     
==========================================
+ Hits        45778    46665     +887     
- Misses      55159    55676     +517     
- Partials     2149     2174      +25     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <ø> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/config_change.go 0.00% <0.00%> (ø)
cmd/setup/setup.go 14.67% <0.00%> (-0.42%) ⬇️
internal/api/grpc/settings/v2/settings.go 0.00% <0.00%> (ø)
internal/api/http/header.go 12.00% <ø> (ø)
internal/api/http/middleware/auth_interceptor.go 12.19% <0.00%> (ø)
internal/api/ui/login/renderer.go 10.55% <0.00%> (-0.09%) ⬇️
... and 36 more

... and 9 files with indirect coverage changes

@livio-a livio-a enabled auto-merge May 16, 2023 06:44
@livio-a livio-a merged commit a77f299 into main May 16, 2023
10 checks passed
@livio-a livio-a deleted the eventstore-created-at branch May 16, 2023 07:08
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants