Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render authrequest id only if possible #5823

Merged
merged 1 commit into from
May 11, 2023

Conversation

adlerhurst
Copy link
Member

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 3:28pm

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #5823 (a18c5f9) into main (11f0f54) will decrease coverage by 29.61%.
The diff coverage is 31.49%.

@@             Coverage Diff             @@
##             main    #5823       +/-   ##
===========================================
- Coverage   44.40%   14.80%   -29.61%     
===========================================
  Files        1173     1180        +7     
  Lines      103086   104374     +1288     
===========================================
- Hits        45778    15453    -30325     
- Misses      55159    88017    +32858     
+ Partials     2149      904     -1245     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/config_change.go 0.00% <0.00%> (ø)
internal/api/grpc/settings/v2/settings.go 0.00% <0.00%> (ø)
internal/api/http/header.go 12.00% <ø> (ø)
internal/api/http/middleware/auth_interceptor.go 12.19% <0.00%> (ø)
internal/api/ui/console/console.go 24.74% <0.00%> (-5.64%) ⬇️
internal/api/ui/login/renderer.go 10.55% <0.00%> (-0.09%) ⬇️
internal/command/session_model.go 0.00% <0.00%> (ø)
internal/database/type.go 21.81% <0.00%> (-7.46%) ⬇️
internal/domain/permission.go 0.00% <ø> (ø)
... and 32 more

... and 404 files with indirect coverage changes

@adlerhurst adlerhurst merged commit 098c27d into main May 11, 2023
6 of 8 checks passed
@adlerhurst adlerhurst deleted the fix--log-authrequest-id-if-possible branch May 11, 2023 16:02
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants