Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set exhausted cookie with env json #5868

Merged
merged 2 commits into from May 15, 2023

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented May 15, 2023

Reuses methods from http.AccessInterceptor to set the expired or not expired exhausted cookie with the environment.json.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 5:29am

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #5868 (dc3c524) into main (11f0f54) will increase coverage by 0.25%.
The diff coverage is 61.01%.

@@            Coverage Diff             @@
##             main    #5868      +/-   ##
==========================================
+ Coverage   44.40%   44.66%   +0.25%     
==========================================
  Files        1173     1185      +12     
  Lines      103086   104502    +1416     
==========================================
+ Hits        45778    46671     +893     
- Misses      55159    55659     +500     
- Partials     2149     2172      +23     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/config_change.go 0.00% <0.00%> (ø)
internal/api/grpc/settings/v2/settings.go 0.00% <0.00%> (ø)
internal/api/http/header.go 12.00% <ø> (ø)
internal/api/http/middleware/auth_interceptor.go 12.19% <0.00%> (ø)
internal/api/ui/login/renderer.go 10.55% <0.00%> (-0.09%) ⬇️
internal/domain/permission.go 0.00% <ø> (ø)
internal/domain/policy_login.go 60.00% <0.00%> (+22.50%) ⬆️
internal/repository/session/aggregate.go 0.00% <0.00%> (ø)
internal/repository/session/session.go 0.00% <0.00%> (ø)
... and 32 more

... and 5 files with indirect coverage changes

@livio-a livio-a merged commit 0e251a2 into main May 15, 2023
10 checks passed
@livio-a livio-a deleted the friendly-quota-depleted-screen-backend-env branch May 15, 2023 06:51
adlerhurst added a commit that referenced this pull request May 17, 2023
* feat: enable grpc server reflection

* add server reflection to Probes list

* fix(eventstore): new column to test clock_timestamp()

* fix(eventstore): use creation_date for existing columns

* fix(eventstore): backfill column

* fix(step11): execute step 10 to make sure events are in correct order

* chore: speed up local console docker build (#5824)

Co-authored-by: Livio Spring <livio.a@gmail.com>

* docs(legal): editorial changes (#5828)

* docs(legal): editorial changes

* remove from tos

* docs: add generated docs to gitignore (#5827)

* fix: set exhausted cookie with env json (#5868)

* fix: set exhausted cookie with env json

* lint

* docs(nginx): fix nginx directory, system api proto description (#5809)

Co-authored-by: Elio Bischof <elio@zitadel.com>

* docs(contributing): don't repeat yourself (#5869)

* ng 16

* material cdk

* module imports, rmn @accounts

* deps

* lint

* buf

* cache to registry

* push

* var

* ref

* vars

* so?

* next

* new buildx

* params

---------

Co-authored-by: Tim Möhlmann <tim+github@zitadel.com>
Co-authored-by: Elio Bischof <elio@zitadel.com>
Co-authored-by: Livio Spring <livio.a@gmail.com>
Co-authored-by: mffap <mpa@zitadel.com>
Co-authored-by: kotoriのねこ <minamiktr@outlook.com>
Co-authored-by: Max Peintner <max@caos.ch>
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants