Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display loginname in machine client credentials #5936

Merged
merged 3 commits into from
May 26, 2023

Conversation

muhlemmer
Copy link
Contributor

Take the preferred login name from the query side, so that it is printed correctly in the client credential creation prompt for a machine user.

Fixes #5919

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 0:38am

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #5936 (85cd9d1) into main (383e68b) will increase coverage by 0.85%.
The diff coverage is 55.31%.

@@            Coverage Diff             @@
##             main    #5936      +/-   ##
==========================================
+ Coverage   44.66%   45.51%   +0.85%     
==========================================
  Files        1187     1190       +3     
  Lines      104527   105747    +1220     
==========================================
+ Hits        46682    48135    +1453     
+ Misses      55672    55360     -312     
- Partials     2173     2252      +79     
Impacted Files Coverage Δ
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
internal/api/http/cookie.go 26.08% <0.00%> (ø)
internal/api/http/middleware/access_interceptor.go 18.51% <0.00%> (ø)
internal/api/ui/console/console.go 22.64% <0.00%> (-0.66%) ⬇️
internal/command/user_human_webauthn.go 13.89% <0.00%> (+11.96%) ⬆️
internal/command/user_machine_secret.go 83.20% <ø> (-0.27%) ⬇️
internal/database/postgres/config.go 54.32% <0.00%> (+2.59%) ⬆️
internal/domain/idp.go 15.38% <0.00%> (+3.95%) ⬆️
... and 35 more

... and 31 files with indirect coverage changes

@muhlemmer muhlemmer marked this pull request as draft May 26, 2023 11:20
@muhlemmer muhlemmer marked this pull request as ready for review May 26, 2023 11:52
@muhlemmer muhlemmer enabled auto-merge (squash) May 26, 2023 11:56
@muhlemmer muhlemmer merged commit d5eaa8f into main May 26, 2023
10 checks passed
@muhlemmer muhlemmer deleted the fix-cliendid-machine-user branch May 26, 2023 13:04
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service account client credenitials popup client id is wrong
2 participants