Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): update chunks in step 11 #5965

Merged
merged 1 commit into from
Jun 2, 2023
Merged

fix(setup): update chunks in step 11 #5965

merged 1 commit into from
Jun 2, 2023

Conversation

adlerhurst
Copy link
Member

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@adlerhurst adlerhurst self-assigned this Jun 2, 2023
@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 9:05am

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #5965 (f0c939e) into main (383e68b) will increase coverage by 0.84%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             main    #5965      +/-   ##
==========================================
+ Coverage   44.66%   45.50%   +0.84%     
==========================================
  Files        1187     1190       +3     
  Lines      104527   105789    +1262     
==========================================
+ Hits        46682    48135    +1453     
+ Misses      55672    55402     -270     
- Partials     2173     2252      +79     
Impacted Files Coverage Δ
cmd/setup/11.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
internal/api/http/cookie.go 26.08% <0.00%> (ø)
internal/api/http/middleware/access_interceptor.go 18.51% <0.00%> (ø)
internal/api/ui/console/console.go 22.64% <0.00%> (-0.66%) ⬇️
internal/command/user_human_webauthn.go 13.89% <0.00%> (+11.96%) ⬆️
internal/command/user_machine_secret.go 83.20% <ø> (-0.27%) ⬇️
internal/database/postgres/config.go 54.32% <0.00%> (+2.59%) ⬆️
... and 36 more

... and 31 files with indirect coverage changes

@adlerhurst adlerhurst merged commit ebca7b6 into main Jun 2, 2023
10 checks passed
@adlerhurst adlerhurst deleted the step11 branch June 2, 2023 09:31
adlerhurst added a commit that referenced this pull request Jun 2, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants