-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: warning if backdrop click or escape key is pressed when new action form is dirty #5989
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #5989 +/- ##
==========================================
+ Coverage 44.66% 45.87% +1.21%
==========================================
Files 1187 1192 +5
Lines 104527 106622 +2095
==========================================
+ Hits 46682 48915 +2233
+ Misses 55672 55400 -272
- Partials 2173 2307 +134
|
hei @doncicuto thanks for your work. |
@peintnermax can you have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort.. 🙏 I've made a suggestion to use typed forms and initialize it on top. What do you think?
console/src/app/pages/actions/add-action-dialog/add-action-dialog.component.ts
Outdated
Show resolved
Hide resolved
console/src/app/pages/actions/add-action-dialog/add-action-dialog.component.ts
Outdated
Show resolved
Hide resolved
console/src/app/pages/actions/add-action-dialog/add-action-dialog.component.ts
Outdated
Show resolved
Hide resolved
console/src/app/pages/actions/add-action-dialog/add-action-dialog.component.ts
Outdated
Show resolved
Hide resolved
Thanks a lot @peintnermax, as always, for your review. I'll submit a PR including your suggested changes. |
🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
As a dev, I want to get a warning when I click anywhere outside the modal or the escape key is pressed
Acceptance Criteria
Deviation from acceptance criteria:
This is a sample video showing backdrop click or when escape key is pressed:
output.mp4
Would close #5681
Definition of Ready