Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: internationalization Bulgarian #5998

Merged
merged 19 commits into from
Jun 16, 2023
Merged

Conversation

dmushkov
Copy link
Contributor

@dmushkov dmushkov commented Jun 9, 2023

Provides login, messages, and console in Bulgarian.
Adds missing language references to fr, it and zh where other languages are used.

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 1:33pm

@dmushkov dmushkov changed the title Feature BG bulgarian language Jun 9, 2023
@dmushkov dmushkov changed the title bulgarian language feat: internationalization Bulgarian Jun 9, 2023
# Conflicts:
#	console/src/app/app.component.ts
Copy link
Member

@peintnermax peintnermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your great work and your contribution. We have made some changes recently so can you please remerge main. Rest looks good to me 👍

console/src/app/app.component.ts Outdated Show resolved Hide resolved
console/src/app/app.component.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #5998 (4db54f3) into main (383e68b) will increase coverage by 1.27%.
The diff coverage is 56.37%.

@@            Coverage Diff             @@
##             main    #5998      +/-   ##
==========================================
+ Coverage   44.66%   45.93%   +1.27%     
==========================================
  Files        1187     1194       +7     
  Lines      104527   106722    +2195     
==========================================
+ Hits        46682    49018    +2336     
+ Misses      55672    55392     -280     
- Partials     2173     2312     +139     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.41% <0.00%> (-0.27%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
... and 70 more

... and 29 files with indirect coverage changes

Copy link
Member

@peintnermax peintnermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @dmushkov 🎉

We appreciate your work and if you're interested we would send you some swag. Just send us a mail to hi@zitadel.com. We will then send you a form with some questions about the shirt size and other details 👍

@peintnermax peintnermax merged commit 4378eb7 into zitadel:main Jun 16, 2023
11 checks passed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants