Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil pointer on create instance add machine #6000

Merged
merged 5 commits into from
Jun 15, 2023
Merged

fix: nil pointer on create instance add machine #6000

merged 5 commits into from
Jun 15, 2023

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Jun 9, 2023

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz stebenz requested a review from muhlemmer June 9, 2023 12:01
@stebenz stebenz self-assigned this Jun 9, 2023
@vercel
Copy link

vercel bot commented Jun 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 5:50am

@stebenz stebenz linked an issue Jun 9, 2023 that may be closed by this pull request
[Bug]: Nil pointer error while creating an instance #5960
Closed
2 tasks
@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited

Codecov Report

Merging #6000 (604ded7) into main (383e68b) will increase coverage by 1.27%.
The diff coverage is 56.95%.

@@            Coverage Diff             @@
##             main    #6000      +/-   ##
==========================================
+ Coverage   44.66%   45.93%   +1.27%     
==========================================
  Files        1187     1194       +7     
  Lines      104527   106704    +2177     
==========================================
+ Hits        46682    49013    +2331     
+ Misses      55672    55378     -294     
- Partials     2173     2313     +140
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.41% <0.00%> (-0.27%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
... and 67 more

... and 30 files with indirect coverage changes

muhlemmer
muhlemmer previously approved these changes Jun 9, 2023
View reviewed changes
@muhlemmer muhlemmer self-requested a review June 12, 2023 08:34
muhlemmer
muhlemmer previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

cmd/setup/03.go Outdated Show resolved Hide resolved
cmd/setup/03.go Show resolved Hide resolved
cmd/setup/03.go Outdated Show resolved Hide resolved
cmd/defaults.yaml Outdated Show resolved Hide resolved
internal/api/grpc/system/instance_converter.go Outdated Show resolved Hide resolved
@stebenz stebenz requested a review from livio-a June 13, 2023 14:31
@livio-a livio-a enabled auto-merge (squash) June 15, 2023 05:47
@livio-a livio-a merged commit 855d6b1 into main Jun 15, 2023
10 checks passed
@livio-a livio-a deleted the instance-pat-nil-fix branch June 15, 2023 06:16
livio-a added a commit that referenced this pull request Jun 15, 2023
@stebenz @livio-a
fix: nil pointer on create instance add machine (#6000)
cc12e91 
* fix: nil pointer on create instance add machine

* fix: instance setup with machine user pat

* fix: correct logic to write pat and key from setup without configurable scope

---------

Co-authored-by: Livio Spring <livio.a@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlemmer muhlemmer muhlemmer approved these changes

@livio-a livio-a Awaiting requested review from livio-a

Assignees

@stebenz stebenz

Labels
released on @merge-eventstore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Nil pointer error while creating an instance
3 participants
@stebenz @muhlemmer @livio-a