Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(migrate): applications #6001

Merged
merged 2 commits into from
Jun 9, 2023
Merged

docs(migrate): applications #6001

merged 2 commits into from
Jun 9, 2023

Conversation

mffap
Copy link
Member

@mffap mffap commented Jun 9, 2023

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented Jun 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 2:06pm

@mffap mffap requested a review from fforootd June 9, 2023 13:53
fforootd
fforootd reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@fforootd fforootd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment.

docs/docs/guides/migrate/introduction.md Outdated Show resolved Hide resolved
@mffap @fforootd
Update docs/docs/guides/migrate/introduction.md
2b4af82 
Co-authored-by: Florian Forster <florian@zitadel.com>
@mffap mffap enabled auto-merge (squash) June 9, 2023 14:02
@mffap mffap requested a review from fforootd June 9, 2023 14:02
@mffap mffap merged commit 0a035b6 into main Jun 9, 2023
6 checks passed
@mffap mffap deleted the mpa_docsMigrate_20230609 branch June 9, 2023 14:07
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fforootd fforootd fforootd approved these changes

Assignees
No one assigned
Labels
released on @merge-eventstore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mffap @fforootd