Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back button in detail view should not navigate to create dialog again #6018

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

doncicuto
Copy link
Contributor

@mffap detected in #5069 that after creating a new client and go on the back button the create app dialog starts again.

This is a video showing the current situation:

before.mp4

The same behavior should apper after creating a project, a user, a machine user and a project role. As a workaround once of those elements are created I suggest adding a query param: new=true. When the back directive is applied after clicking the back button if the new param exists, a new back navigation is performed so the create dialog is not shown. Maybe is not the most elegant solution with going back twice.

This is a video showing the proposed change:

after.mp4

This PR should close #5069.

Acceptance Criteria

  • I land on the project detail when clicking back (<--) on the application detail
  • I land on the project detail when clicking back (<--) on the application detail when i just created the application

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 6:35am

@hifabienne
Copy link
Member

@doncicuto Thanks for the pr.
@peintnermax can you have a look at it?

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #6018 (3aa8483) into main (383e68b) will increase coverage by 1.22%.
The diff coverage is 57.05%.

@@            Coverage Diff             @@
##             main    #6018      +/-   ##
==========================================
+ Coverage   44.66%   45.88%   +1.22%     
==========================================
  Files        1187     1192       +5     
  Lines      104527   106622    +2095     
==========================================
+ Hits        46682    48927    +2245     
+ Misses      55672    55390     -282     
- Partials     2173     2305     +132     
Impacted Files Coverage Δ
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.54% <0.00%> (-0.14%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
internal/api/http/cookie.go 26.08% <0.00%> (ø)
... and 63 more

... and 29 files with indirect coverage changes

Copy link
Member

@peintnermax peintnermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍 . I've just added a small change such that the subscription of the params is cancelled.

console/src/app/directives/back/back.directive.ts Outdated Show resolved Hide resolved
@doncicuto
Copy link
Contributor Author

Thanks a lot @peintnermax for your review, changes have been applied

@peintnermax peintnermax enabled auto-merge (squash) June 14, 2023 06:31
@peintnermax peintnermax merged commit c98307f into zitadel:main Jun 14, 2023
10 checks passed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Back button after creating a client app
3 participants