-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: back button in detail view should not navigate to create dialog again #6018
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@doncicuto Thanks for the pr. |
Codecov Report
@@ Coverage Diff @@
## main #6018 +/- ##
==========================================
+ Coverage 44.66% 45.88% +1.22%
==========================================
Files 1187 1192 +5
Lines 104527 106622 +2095
==========================================
+ Hits 46682 48927 +2245
+ Misses 55672 55390 -282
- Partials 2173 2305 +132
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 👍 . I've just added a small change such that the subscription of the params is cancelled.
Thanks a lot @peintnermax for your review, changes have been applied |
🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@mffap detected in #5069 that after creating a new client and go on the back button the create app dialog starts again.
This is a video showing the current situation:
before.mp4
The same behavior should apper after creating a project, a user, a machine user and a project role. As a workaround once of those elements are created I suggest adding a query param: new=true. When the back directive is applied after clicking the back button if the new param exists, a new back navigation is performed so the create dialog is not shown. Maybe is not the most elegant solution with going back twice.
This is a video showing the proposed change:
after.mp4
This PR should close #5069.
Acceptance Criteria
Definition of Ready