Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): url safe base64 to array buffer #6019

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix(console): url safe base64 to array buffer #6019

merged 2 commits into from
Jun 13, 2023

Conversation

peintnermax
Copy link
Member

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 4:56am

@peintnermax peintnermax changed the title fix(console): base64 to array buffer fix(console): url safe base64 to array buffer Jun 12, 2023
@peintnermax peintnermax marked this pull request as ready for review June 12, 2023 12:11
@peintnermax peintnermax requested a review from livio-a June 12, 2023 12:11
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #6019 (d565fea) into main (383e68b) will increase coverage by 1.22%.
The diff coverage is 57.05%.

@@            Coverage Diff             @@
##             main    #6019      +/-   ##
==========================================
+ Coverage   44.66%   45.88%   +1.22%     
==========================================
  Files        1187     1192       +5     
  Lines      104527   106622    +2095     
==========================================
+ Hits        46682    48928    +2246     
+ Misses      55672    55390     -282     
- Partials     2173     2304     +131     
Impacted Files Coverage Δ
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.54% <0.00%> (-0.14%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
internal/api/http/cookie.go 26.08% <0.00%> (ø)
... and 63 more

... and 34 files with indirect coverage changes

@livio-a livio-a enabled auto-merge (squash) June 13, 2023 04:52
@livio-a livio-a merged commit e39d1b7 into main Jun 13, 2023
10 checks passed
@livio-a livio-a deleted the cnsl-base64 branch June 13, 2023 05:37
livio-a added a commit that referenced this pull request Jun 22, 2023
fix: console base64 to array buffer

Co-authored-by: Livio Spring <livio.a@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants