Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update linking users if action changed values #6024

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix: update linking users if action changed values #6024

merged 2 commits into from
Jun 15, 2023

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Jun 13, 2023

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz stebenz requested a review from livio-a June 13, 2023 12:56
@stebenz stebenz self-assigned this Jun 13, 2023
@vercel
Copy link

vercel bot commented Jun 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 6:32am

@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited

Codecov Report

Merging #6024 (ad4c3b1) into main (383e68b) will increase coverage by 1.27%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##             main    #6024      +/-   ##
==========================================
+ Coverage   44.66%   45.93%   +1.27%     
==========================================
  Files        1187     1194       +7     
  Lines      104527   106716    +2189     
==========================================
+ Hits        46682    49015    +2333     
+ Misses      55672    55388     -284     
- Partials     2173     2313     +140
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.41% <0.00%> (-0.27%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
... and 68 more

... and 32 files with indirect coverage changes

@livio-a livio-a enabled auto-merge (squash) June 15, 2023 06:36
@livio-a livio-a merged commit 2d13d41 into main Jun 15, 2023
10 checks passed
@livio-a livio-a deleted the auto-creation-linking-users branch June 15, 2023 07:02
livio-a added a commit that referenced this pull request Jun 15, 2023
@stebenz @livio-a
fix: update linking users if action changed values (#6024)
480a82b 
Co-authored-by: Livio Spring <livio.a@gmail.com>
livio-a added a commit that referenced this pull request Jun 16, 2023
@stebenz @livio-a
fix: update linking users if action changed values (#6024)
d714b82 
Co-authored-by: Livio Spring <livio.a@gmail.com>
livio-a added a commit that referenced this pull request Jun 22, 2023
@stebenz @livio-a
fix: update linking users if action changed values (#6024)
5b664b2 
Co-authored-by: Livio Spring <livio.a@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livio-a livio-a livio-a approved these changes

Assignees

@stebenz stebenz

Labels
released on @merge-eventstore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stebenz @livio-a