Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): implement user register tOTP #6030

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Conversation

muhlemmer
Copy link
Contributor

@muhlemmer muhlemmer commented Jun 14, 2023

This implement TOTP registration for the user v2alpha API.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Related #5470

@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 10:05am

@muhlemmer muhlemmer requested a review from livio-a June 14, 2023 15:53
@muhlemmer muhlemmer marked this pull request as ready for review June 14, 2023 15:56
@muhlemmer muhlemmer enabled auto-merge (squash) June 14, 2023 15:57
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #6030 (0c114aa) into main (383e68b) will increase coverage by 1.33%.
The diff coverage is 56.88%.

@@            Coverage Diff             @@
##             main    #6030      +/-   ##
==========================================
+ Coverage   44.66%   45.99%   +1.33%     
==========================================
  Files        1187     1196       +9     
  Lines      104527   106778    +2251     
==========================================
+ Hits        46682    49108    +2426     
+ Misses      55672    55357     -315     
- Partials     2173     2313     +140     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.41% <0.00%> (-0.27%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
... and 75 more

... and 31 files with indirect coverage changes

@muhlemmer muhlemmer changed the title feat(v2): implement user register OTP feat(v2): implement user register tOTP Jun 14, 2023
@muhlemmer muhlemmer merged commit 09aafb3 into main Jun 20, 2023
10 checks passed
@muhlemmer muhlemmer deleted the feat-register-factors-otp branch June 20, 2023 10:36
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants