Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event handling on UserIDPLinkWriteModel #6054

Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix: event handling on UserIDPLinkWriteModel #6054

merged 3 commits into from
Jun 21, 2023

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Jun 19, 2023

Fixes a problem noticeable when deleting IDPs of a user, where at least the last IDP link could not get deleted.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 5:58am

@livio-a livio-a marked this pull request as ready for review June 19, 2023 13:42
@livio-a livio-a enabled auto-merge (squash) June 19, 2023 13:42
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #6054 (7c23dd3) into main (383e68b) will increase coverage by 1.66%.
The diff coverage is 58.46%.

@@            Coverage Diff             @@
##             main    #6054      +/-   ##
==========================================
+ Coverage   44.66%   46.32%   +1.66%     
==========================================
  Files        1187     1198      +11     
  Lines      104527   107094    +2567     
==========================================
+ Hits        46682    49611    +2929     
+ Misses      55672    55126     -546     
- Partials     2173     2357     +184     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.41% <0.00%> (-0.27%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 1.82% <0.00%> (+1.82%) ⬆️
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
... and 80 more

... and 55 files with indirect coverage changes

@livio-a livio-a merged commit 7e6434f into main Jun 21, 2023
10 checks passed
@livio-a livio-a deleted the idp-remove-fix branch June 21, 2023 06:30
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants