Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): list authentication method types in user api v2 #6058

Merged
merged 10 commits into from
Jun 20, 2023
Merged

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented Jun 20, 2023

Adds possibility to list possible authentication methods of a user.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

closes #5985

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 4:00pm

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6058 (e111f09) into main (383e68b) will increase coverage by 1.71%.
The diff coverage is 46.91%.

❗ Current head e111f09 differs from pull request most recent head c8e6bcd. Consider uploading reports for the commit c8e6bcd to get more accurate results

@@            Coverage Diff             @@
##             main    #6058      +/-   ##
==========================================
+ Coverage   44.66%   46.37%   +1.71%     
==========================================
  Files        1187      788     -399     
  Lines      104527    80826   -23701     
==========================================
- Hits        46682    37481    -9201     
+ Misses      55672    41602   -14070     
+ Partials     2173     1743     -430     
Impacted Files Coverage Δ
internal/api/authz/user.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/fields.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 2.77% <0.00%> (-44.45%) ⬇️
internal/api/grpc/system/instance_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/user/v2/server.go 0.00% <0.00%> (-100.00%) ⬇️
internal/api/http/middleware/access_interceptor.go 0.00% <0.00%> (-18.52%) ⬇️
... and 54 more

... and 602 files with indirect coverage changes

internal/query/query.go Outdated Show resolved Hide resolved
@muhlemmer muhlemmer self-requested a review June 20, 2023 10:11
Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 2 small comments. (see also the seperate one before this review).

internal/domain/permission.go Show resolved Hide resolved
muhlemmer
muhlemmer previously approved these changes Jun 20, 2023
@muhlemmer muhlemmer merged commit 7046194 into main Jun 20, 2023
8 checks passed
@muhlemmer muhlemmer deleted the auth-methods branch June 20, 2023 16:23
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Authentication Methods
2 participants