Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): typo in register u2f endpoint summary #6059

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

muhlemmer
Copy link
Contributor

This PR updates the summary for v2 alpha, user u2f registration. There was a copy/paste type which we forgot to change from passkey to u2f.

@muhlemmer muhlemmer enabled auto-merge (squash) June 20, 2023 10:38
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 10:47am

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6059 (932f814) into main (383e68b) will increase coverage by 1.32%.
The diff coverage is 56.88%.

@@            Coverage Diff             @@
##             main    #6059      +/-   ##
==========================================
+ Coverage   44.66%   45.98%   +1.32%     
==========================================
  Files        1187     1196       +9     
  Lines      104527   106778    +2251     
==========================================
+ Hits        46682    49105    +2423     
+ Misses      55672    55359     -313     
- Partials     2173     2314     +141     
Impacted Files Coverage Δ
cmd/setup/03.go 0.00% <0.00%> (ø)
cmd/setup/10.go 0.00% <0.00%> (ø)
cmd/setup/11.go 0.00% <0.00%> (ø)
cmd/setup/config.go 0.00% <ø> (ø)
cmd/setup/setup.go 14.41% <0.00%> (-0.27%) ⬇️
internal/api/grpc/admin/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/management/idp.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/server/gateway.go 47.22% <0.00%> (ø)
... and 75 more

... and 32 files with indirect coverage changes

@muhlemmer muhlemmer merged commit 83da9ca into main Jun 20, 2023
10 checks passed
@muhlemmer muhlemmer deleted the fix-u2f_reg-typo branch June 20, 2023 11:06
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants