fix(login): (re)allow HTML in custom login texts #7575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
livio-a
changed the title
adlerhurst
approved these changes
Mar 15, 2024
2 tasks
livio-a
added a commit
that referenced
this pull request
Mar 15, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
livio-a
added a commit
that referenced
this pull request
Mar 15, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
livio-a
added a commit
that referenced
this pull request
Mar 15, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
livio-a
added a commit
that referenced
this pull request
Mar 18, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
livio-a
added a commit
that referenced
this pull request
Mar 18, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
livio-a
added a commit
that referenced
this pull request
Mar 18, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
livio-a
added a commit
that referenced
this pull request
Mar 18, 2024
fix: allow HTML in custom login texts (cherry picked from commit 6c3f48f)
|
🎉 This PR is included in version 2.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fixed the template rendering to prevent HTML injection by queries, this changed also custom texts in the login UI, which include HTML. These are now rendered as raw strings.
This PR changes the behaviour back for custom texts to also render HTML.
To do so, the translation function (used to provide the texts in the login UI) returns now a
template.HTMLinstead of astring.closes #7556
Definition of Ready