New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update url to redirect to name change url #7683
fix: Update url to redirect to name change url #7683
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @vigneshsankariyer1234567890 thanks for the PR. |
@livio-a That makes sense, originally the only difference between the "back" button and the "login" button was the inclusion of the AuthRequestId. I will remove the button altogether, thank you for the clarification! |
Perfect. Thanks for the fix! |
🎉 This PR is included in version 2.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Definition of Ready
Solves #7456 . Given an admin had configured at least one external IdP, when a user clicked on the Register button to register as a new user, the user would be redirected to the Register Options page. However, while clicking on the back arrow returns the user back to the original page to either log in or register, clicking on the Login page redirects to the default instance page, since the authRequestId is not included as a param.
Instead, it should redirect to the correct login page accordingly.
The changes add the authRequestID within the href of the Login button as well.
Screen.Recording.2024-04-01.at.12.36.16.PM.mov