Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update url to redirect to name change url #7683

Conversation

vigneshsankariyer1234567890
Copy link
Contributor

Definition of Ready

Solves #7456 . Given an admin had configured at least one external IdP, when a user clicked on the Register button to register as a new user, the user would be redirected to the Register Options page. However, while clicking on the back arrow returns the user back to the original page to either log in or register, clicking on the Login page redirects to the default instance page, since the authRequestId is not included as a param.

Instead, it should redirect to the correct login page accordingly.

The changes add the authRequestID within the href of the Login button as well.

Screen.Recording.2024-04-01.at.12.36.16.PM.mov
  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 6:05am

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Apr 1, 2024
@vigneshsankariyer1234567890 vigneshsankariyer1234567890 changed the title Update url to redirect to name change url fix(bug): Update url to redirect to name change url Apr 2, 2024
@vigneshsankariyer1234567890 vigneshsankariyer1234567890 changed the title fix(bug): Update url to redirect to name change url fix: Update url to redirect to name change url Apr 2, 2024
@muhlemmer muhlemmer requested a review from livio-a April 2, 2024 09:32
@livio-a
Copy link
Member

livio-a commented Apr 3, 2024

Hey @vigneshsankariyer1234567890 thanks for the PR.
I noticed that the latest change does not work and just had an internal discussion.
Since there already is a "back" button (arrow at the top), which exactly does what the "Login" button should achieve, the best option currently is to just remove the "Login" button entirely.

@vigneshsankariyer1234567890
Copy link
Contributor Author

@livio-a That makes sense, originally the only difference between the "back" button and the "login" button was the inclusion of the AuthRequestId.

I will remove the button altogether, thank you for the clarification!

@livio-a livio-a enabled auto-merge (squash) April 4, 2024 05:43
@livio-a
Copy link
Member

livio-a commented Apr 4, 2024

@livio-a That makes sense, originally the only difference between the "back" button and the "login" button was the inclusion of the AuthRequestId.

I will remove the button altogether, thank you for the clarification!

Perfect. Thanks for the fix!

@livio-a livio-a merged commit a988b9c into zitadel:main Apr 4, 2024
25 checks passed
Copy link

🎉 This PR is included in version 2.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants