-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import totp in add human user with secret #7936
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for your contribution! 🎉Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments, the integration test is also failing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7936 +/- ##
=======================================
Coverage 63.09% 63.09%
=======================================
Files 1335 1335
Lines 110633 110671 +38
=======================================
+ Hits 69805 69829 +24
- Misses 36865 36876 +11
- Partials 3963 3966 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 2.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Which Problems Are Solved
To create a user directly with the provided TOTP secret, which can then be used for the session API to log in.
How the Problems Are Solved
Add the secret to the AddHumanUser request and result in the regular TOTP events.
Additional Changes
Small refactoring with the handling of the TOTP secret encryption.
Additional Context
Closes #7881