Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import totp in add human user with secret #7936

Merged
merged 5 commits into from
May 14, 2024
Merged

fix: import totp in add human user with secret #7936

merged 5 commits into from
May 14, 2024

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented May 10, 2024

Which Problems Are Solved

To create a user directly with the provided TOTP secret, which can then be used for the session API to log in.

How the Problems Are Solved

Add the secret to the AddHumanUser request and result in the regular TOTP events.

Additional Changes

Small refactoring with the handling of the TOTP secret encryption.

Additional Context

Closes #7881

@stebenz stebenz self-assigned this May 10, 2024
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 2:18pm

Copy link

github-actions bot commented May 10, 2024

Thanks for your contribution! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, the integration test is also failing.

internal/api/grpc/session/v2/session_integration_test.go Outdated Show resolved Hide resolved
proto/zitadel/user/v2beta/user_service.proto Show resolved Hide resolved
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.09%. Comparing base (15d5338) to head (ba23b98).

Files Patch % Lines
internal/command/user_v2_human.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7936   +/-   ##
=======================================
  Coverage   63.09%   63.09%           
=======================================
  Files        1335     1335           
  Lines      110633   110671   +38     
=======================================
+ Hits        69805    69829   +24     
- Misses      36865    36876   +11     
- Partials     3963     3966    +3     
Flag Coverage Δ
core-integration-tests-postgres 63.09% <95.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stebenz stebenz merged commit 0e9ebed into main May 14, 2024
27 checks passed
@stebenz stebenz deleted the import-totp branch May 14, 2024 07:20
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import TOTP secrets
2 participants