Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session): allow update of session without token #7963

Merged
merged 6 commits into from
May 22, 2024

Conversation

muhlemmer
Copy link
Contributor

@muhlemmer muhlemmer commented May 16, 2024

Which Problems Are Solved

The session update requires the current session token as argument.
Since this adds extra complexity but no real additional security and prevents case like magic links, we want to remove this requirement.

We still require the session token on other resouces / endpoints, e.g. for finalizing the auth request or on idp intents.

How the Problems Are Solved

  • Removed the session token verifier in the Update Session GRPc call.
  • Removed the session token from login UI examples session update calls

Additional Changes

  • none

Additional Context

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 5:36am

Copy link

github-actions bot commented May 16, 2024

Thanks for your contribution! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

@muhlemmer muhlemmer marked this pull request as ready for review May 21, 2024 09:33
@muhlemmer muhlemmer requested a review from livio-a May 21, 2024 09:34
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.76%. Comparing base (07f91e4) to head (e2e23cf).

Current head e2e23cf differs from pull request most recent head 284f23b

Please upload reports for the commit 284f23b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7963      +/-   ##
==========================================
+ Coverage   62.74%   62.76%   +0.01%     
==========================================
  Files        1341     1341              
  Lines      111033   111028       -5     
==========================================
+ Hits        69673    69688      +15     
+ Misses      37432    37417      -15     
+ Partials     3928     3923       -5     
Flag Coverage Δ
core-integration-tests-postgres 62.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer merged commit 5b1160d into main May 22, 2024
25 checks passed
@muhlemmer muhlemmer deleted the feat-session-without-token branch May 22, 2024 05:56
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Session change without session token
2 participants