-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest archiver versions break pptx output in some cases #20
Comments
see also: archiverjs/node-archiver#60 |
Thanks for letting me know about it. I'll do lock it to 0.4.10 On Fri, Feb 7, 2014 at 2:02 AM, Seth Pollack notifications@github.comwrote:
|
i highly recommend |
Thanks guys. |
Line 318 in 60dfa66
really should be catching the error and either emitting it back to archive (for existing handler to work) or call |
definitely we should be checking and handling errors from archiver here in the officegen code. this should also help get info on whatever root problem was causing these failures for me earlier. |
Officegen makes use of the archiver module. With the following module set (i.e. what you get from a default install of latest officegen right now), we get intermittent failures during pptx output. Specifically, we make the call to pptx.generate(), but it often hangs partway through, never emiting either the error or finalize events.
However, with achiver rolled back to 0.4.10, it works reliably. So it isn't an officegen issue per se.
The environment where we are testing and see issues with archiver@0.5.2 is using node 0.8.26, running on linux (heroku dynos). Interestingly, the exact same code running on my OSX dev machine doesn't have this issue. Something subtle is happening here. It happens quite often with longer powerpoints; single slide ones seem to succeed.
We put in some logging within the officegen generate() code, and were able to see that it dies inside of archiver. The exact spot within the pptx export where it dies varies from run to run.
For now, we are working around this via an npm shrinkwrap file that locks us to the old archiver@0.4.10.
The reason i'm raising the issue here is to warn officegen users, and to see if anyone else has anyone else hit this issue already, or can repro it.
I'd like to open a ticket with archiver, but i don't have a great repro case currently that doesn't involve a ton of other code.
Also, @Ziv-Barber you might want to lock officegen to archiver:~0.4.10 for now?
The text was updated successfully, but these errors were encountered: