Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeListener -> off #194

Merged
merged 1 commit into from
Mar 1, 2024
Merged

removeListener -> off #194

merged 1 commit into from
Mar 1, 2024

Conversation

ob1
Copy link
Contributor

@ob1 ob1 commented Feb 22, 2024

Puppeteer deprecated the removeListener some time ago in favor of off and in latest version they removed removeListener entirely

Copy link
Owner

@zivl zivl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
Do you think this will require a major version increment?

@ob1
Copy link
Contributor Author

ob1 commented Feb 25, 2024

Do you think this will require a major version increment?

My personal view is "no".
I think it's better for the world to get this by default rather than having to bump a major.
Users with very old puppeteer might break, and then will have a choice - either upgrade puppeteer (which they should) or use a fixed version of the older version of this testkit.

@zivl zivl merged commit db55906 into zivl:master Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants