Optimize bucketing

zix99 · Sep 16, 2022 · a6418a6 · a6418a6
1 parent af6436c
commit a6418a6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/docs/usage/expressions.md b/docs/usage/expressions.md
@@ -88,7 +88,7 @@ Evaluates arguments in-order, chosing the first non-empty result.
 
 ### Bucket
 
-Syntax: `{bucket intVal bucketSize}`
+Syntax: `{bucket intVal "bucketSize"}`
 
 Given a value, create equal-sized buckets and place each value in those buckets
 

diff --git a/pkg/expressions/stdlib/funcsCommon.go b/pkg/expressions/stdlib/funcsCommon.go
@@ -23,17 +23,18 @@ func kfBucket(args []KeyBuilderStage) KeyBuilderStage {
 	if len(args) != 2 {
 		return stageLiteral(ErrorArgCount)
 	}
+
+	bucketSize, err := strconv.Atoi(EvalStageOrDefault(args[1], ""))
+	if err != nil {
+		return stageLiteral(ErrorType)
+	}
+
 	return KeyBuilderStage(func(context KeyBuilderContext) string {
 		val, err := strconv.Atoi(args[0](context))
 		if err != nil {
 			return ErrorType
 		}
 
-		bucketSize, err := strconv.Atoi(args[1](context))
-		if err != nil {
-			return ErrorType
-		}
-
 		return strconv.Itoa((val / bucketSize) * bucketSize)
 	})
 }

diff --git a/pkg/expressions/stdlib/funcsTime.go b/pkg/expressions/stdlib/funcsTime.go
@@ -260,7 +260,7 @@ func kfTimeAttr(args []KeyBuilderStage) KeyBuilderStage {
 
 	attrName, hasAttrName := EvalStaticStage(args[1])
 	if !hasAttrName {
-		return stageLiteral(ErrorType)
+		return stageLiteral(ErrorConst)
 	}
 	tz, tzOk := parseTimezoneLocation(EvalStageIndexOrDefault(args, 2, ""))
 	if !tzOk {