Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow reader #66

Merged
merged 10 commits into from Jun 3, 2022
Merged

Follow reader #66

merged 10 commits into from Jun 3, 2022

Conversation

zix99
Copy link
Owner

@zix99 zix99 commented May 28, 2022

Replace gotail with internal file following is a significant performance improvement.
Previous benchmark maxed out at 20-30 MB/sec (Likely mostly because of the single-batched channel from gotail)
New benchmarks max out at 500 MB/sec, and seem limited by disk at that point

@netlify
Copy link

netlify bot commented May 28, 2022

Deploy Preview for raredocs ready!

Name Link
🔨 Latest commit 4871143
🔍 Latest deploy log https://app.netlify.com/sites/raredocs/deploys/629956cbff574c0008634d68
😎 Deploy Preview https://deploy-preview-66--raredocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #66 (4871143) into master (fdbd885) will increase coverage by 0.24%.
The diff coverage is 81.34%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   82.68%   82.92%   +0.24%     
==========================================
  Files          77       80       +3     
  Lines        2870     2964      +94     
==========================================
+ Hits         2373     2458      +85     
- Misses        360      364       +4     
- Partials      137      142       +5     
Impacted Files Coverage Δ
pkg/followreader/followreader.go 0.00% <0.00%> (ø)
pkg/followreader/notify.go 83.33% <83.33%> (ø)
pkg/followreader/poller.go 84.00% <84.00%> (ø)
pkg/extractor/batchers/tailBatcher.go 52.38% <100.00%> (-3.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbd885...4871143. Read the comment docs.

@zix99 zix99 mentioned this pull request May 29, 2022
pkg/followreader/poller.go Outdated Show resolved Hide resolved
@zix99 zix99 merged commit 7651b26 into master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants