Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize memory usage by reducing buffered batches by default #82

Merged
merged 3 commits into from Sep 24, 2022

Conversation

zix99
Copy link
Owner

@zix99 zix99 commented Sep 24, 2022

With default settings, rare used ~50MB consistently. These tweaks and settings lower it to ~10MB while maintaining performance. For io-burst systems, you can tweak up the buffered batches via CLI.

@netlify
Copy link

netlify bot commented Sep 24, 2022

Deploy Preview for raredocs ready!

Name Link
🔨 Latest commit 988d082
🔍 Latest deploy log https://app.netlify.com/sites/raredocs/deploys/632e58482cd4220008c0d661
😎 Deploy Preview https://deploy-preview-82--raredocs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

Codecov Report

Merging #82 (988d082) into master (1e7191b) will decrease coverage by 0.92%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   87.53%   86.60%   -0.93%     
==========================================
  Files          93       93              
  Lines        3633     4359     +726     
==========================================
+ Hits         3180     3775     +595     
- Misses        317      448     +131     
  Partials      136      136              
Impacted Files Coverage Δ
cmd/helpers/extractorBuilder.go 83.24% <100.00%> (-3.61%) ⬇️
pkg/extractor/batchers/fileBatcher.go 73.77% <100.00%> (-0.23%) ⬇️
pkg/extractor/batchers/readerBatcher.go 100.00% <100.00%> (ø)
pkg/extractor/batchers/tailBatcher.go 48.27% <100.00%> (+0.27%) ⬆️
cmd/helpers/summary.go 52.38% <0.00%> (-8.74%) ⬇️
pkg/expressions/stdlib/funcsType.go 70.00% <0.00%> (-5.00%) ⬇️
pkg/expressions/stdlib/funcsComparators.go 72.36% <0.00%> (-4.69%) ⬇️
pkg/followreader/poller.go 80.30% <0.00%> (-3.70%) ⬇️
pkg/expressions/stdlib/funcsCommon.go 78.94% <0.00%> (-3.28%) ⬇️
... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zix99 zix99 merged commit 5edf15b into master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants