Add CSV output support to some aggregators #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for raredocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 89.91% 89.60% -0.32%
==========================================
Files 104 107 +3
Lines 5305 5425 +120
==========================================
+ Hits 4770 4861 +91
- Misses 410 429 +19
- Partials 125 135 +10
|
zix99
commented
Jun 11, 2023
pkg/csv/aggWriters.go
Outdated
| cols := agg.OrderedColumns(sorting.NVNameSorter) | ||
| w.Write(append([]string{""}, cols...)) | ||
| for _, row := range agg.OrderedRows(sorting.NVNameSorter) { | ||
| arr := make([]string, len(cols)+1) |
There was a problem hiding this comment.
could save memory here by make once
zix99
commented
Jun 11, 2023
pkg/csv/aggWriters.go
Outdated
| } | ||
|
|
||
| for _, group := range aggr.Groups(sorting.ByName) { | ||
| row := make([]string, 0) |
zix99
commented
Jun 11, 2023
pkg/csv/aggWriters.go
Outdated
| w.Write(header) | ||
|
|
||
| for _, item := range aggr.ItemsSorted(sorting.NVNameSorter) { | ||
| row := []any{item.Name} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CSV output support to various aggregators. Can output to file or stdout