Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: File opens with <?php #9

Closed
ghost opened this issue Feb 14, 2013 · 4 comments · Fixed by #37
Closed

Bug: File opens with <?php #9

ghost opened this issue Feb 14, 2013 · 4 comments · Fixed by #37

Comments

@ghost
Copy link

ghost commented Feb 14, 2013

The UserController.php file opens with &lt;?php which causes an error: "Whoops. Looks like something went wrong... ReflectionException: Class UserController does not exist". By manually changing this to <?php the page loads properly.

Similarly, the migration file also opens with &lt;?php, but that seems to work fine as the table is created. The downside though is that syntax highlighting in Sublime doesn't work when a file is opened this way b/c Sublime doesn't think it's in a PHP block. So here it doesn't cause an error, but would still probably be preferable to output <?php, if possible.

@andrew13
Copy link
Collaborator

Assuming my patch passes Travis CI here's the fix: #11

@Zizaco
Copy link
Owner

Zizaco commented Feb 14, 2013

Thanks to both of you.
Andrews pull request was accepted: #11

@Zizaco Zizaco closed this as completed Feb 14, 2013
@aleksblendwerk
Copy link

I just added confide (dev-master b44c0d6) to an out-of-the-box Laravel project (laravel/framework version is dev-master b7b0db2) and after running php artisan confide:migration the generated migration file starts with &lt;?php.

@Zizaco
Copy link
Owner

Zizaco commented Mar 20, 2013

The pull request #37 has been merged.
Thanks @j20, @andrew13 and @aleksblendwerk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants