Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix winik states #36

Closed
ThomasThelen opened this issue Nov 5, 2020 · 2 comments · Fixed by #37
Closed

Fix winik states #36

ThomasThelen opened this issue Nov 5, 2020 · 2 comments · Fixed by #37
Labels
bug Something isn't working
Milestone

Comments

@ThomasThelen
Copy link
Collaborator

ThomasThelen commented Nov 5, 2020

When a winik's state is a written, it's written as a tibble. See here for reference. It turns out, some of the values may be null, which tibble won't handle and R won't throw an error (even though the tibble is never created).

Figure out of to fix this.

@ThomasThelen ThomasThelen added the bug Something isn't working label Nov 5, 2020
@ThomasThelen ThomasThelen added this to the 1.0 milestone Nov 5, 2020
@zizroc
Copy link
Owner

zizroc commented Nov 9, 2020

i should be able to fix this. i'll look.

@ThomasThelen
Copy link
Collaborator Author

Looking forward to seeing how this works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants