Add support for loading resources from disk #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasThelen
force-pushed
the
load_resources
branch
from
b3a56c9
to
c06291a
Compare
|
It'll be a bit easier to look at the changes commit by commit. I fixed a few bugs and updated the unit test in subsequent commits. |
ohmannyy
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #33
This pull request adds a
loadmethod to theresource_managerclass that loads resources from disk and adds them to the manager. @ohmannyy the code for loading winiks should look almost identical to this.To test
edit: There's a bit of extra code in
get_statesthat doesn't work, but it never worked before and this is a *bit closer to working. I can remove this extra code of of the pull request if you want!