Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external links - external links in main menu #99

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

OliverObst
Copy link
Contributor

This change adds support for an "external" link in the main menu on the title page.
An external link can be added the keyword "external" to the front matter of a page, the value of the "external" key should be the external URL.
An example page is here: https://evilrobots.ai/

@zjedi
Copy link
Owner

zjedi commented Mar 7, 2023

Looks useful, but we should add an example to demo page, otherwise it could be hard to figure out this feature.
I'm thinking maybe we should also add a visual signal for the user to be aware the link is external. I'll get back to this later.

One of these icons should fit, just have to try which looks better
https://forkaweso.me/Fork-Awesome/icon/external-link/
https://forkaweso.me/Fork-Awesome/icon/external-link-square/

@zjedi zjedi added enhancement New feature or request needs work labels Mar 7, 2023
@zjedi zjedi changed the title added support for external links in main menu external links - external links in main menu Mar 8, 2023
@zjedi zjedi merged commit 234f9f7 into zjedi:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants