Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idris.tmLanguage with 0.99 syntax #11

Merged
merged 3 commits into from Mar 6, 2017

Conversation

be5invis
Copy link
Collaborator

No description provided.

@@ -121,6 +121,12 @@
</array>
</dict>
<dict>
<key>match</key>
<string>(?&lt;!\w)\'\w++(?!')</string>
Copy link
Owner

@zjhmale zjhmale Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly the use case of this mandatory green match?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it will match 'abcde in text 'abcdef'.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't get the point, I think currently 'abcdef' just works like a charm

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me some examples of this syntax change? I just can not get my sense to embrace this change actually 😅.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idris have introduced tagged effects using this syntax:

whatever : Eff ['a ::: STATE, 'b ::: STATE] ()
whatever = do
    x <- ('a :- get)
    'b :- (put x)

So we have to support 'identifier syntax.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just not catch up with the community for months, thanks @be5invis.

@zjhmale
Copy link
Owner

zjhmale commented Feb 22, 2017

Hi @be5invis, sorry for the delay, I was busy these days and did not check out GitHub notifications recently 😅

And for the syntax file, I planned to sync this from atom-package, need to find a way to translate from CSON file to JSON file safely. Because that plugin will be catch up the changes of Idris itself and maintaining another tmLanguage file by our own seems redundant here.

I will merge this first, and then we can discuss the proposal above later 😄

@zjhmale zjhmale closed this Feb 22, 2017
@zjhmale zjhmale reopened this Feb 22, 2017
@be5invis
Copy link
Collaborator Author

be5invis commented Mar 5, 2017

@zjhmale Hmm maybe I should add support for rewrite <term> in <term> either.

@be5invis
Copy link
Collaborator Author

be5invis commented Mar 5, 2017

@zjhmale and tmLanguage is a PLIST file, so that you can convert CSON to JSON first, and then turn it into PLIST.

@zjhmale
Copy link
Owner

zjhmale commented Mar 5, 2017

Thanks for the tip! Actually, VSCode can also work with JSON-defined syntax as expected, so maybe just convert from CSON to JSON is kindly enough 😄 , what do you think?

@zjhmale and tmLanguage is a PLIST file, so that you can convert CSON to JSON first, and then turn it into PLIST.

@zjhmale zjhmale merged commit e587829 into zjhmale:master Mar 6, 2017
@zjhmale zjhmale mentioned this pull request Mar 16, 2017
@be5invis be5invis deleted the be5invis-patch-1 branch April 9, 2017 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants