Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from upstream #6

Open
wants to merge 92 commits into
base: master
Choose a base branch
from
Open

Update from upstream #6

wants to merge 92 commits into from

Conversation

zjp-CN
Copy link
Owner

@zjp-CN zjp-CN commented Apr 10, 2022

No description provided.

Veykril and others added 30 commits July 11, 2021 13:13
We can capture the first identifier with a separate metavariable, and then put it at the end of the enum.
Fixed handling of trailing commas in matcher.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
zjp-CN and others added 30 commits April 17, 2022 18:50
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Better reflects natural ordering of numbers
…ng it I missed this change due to the annotation not being there
For code hidden with `#` there must be a space after the `#`.
I had to do this myself recently and when I looked in this chapter it
was "WIP" so I had to work it out myself. Might as well record it for
the benefit of others.
`mdbook test` reports lots of errors. This commit fixes them, in various
ways.
- Add space after `#` on hidden lines.
- Add `compile_fail` to all examples that are intended to not compile.
- Add `text` to non-code blocks.
- Add `ignore` to examples using `#![feature(...)]`, which requires nightly.
  Unfortunate, but I can't see a better way to handle these.
- Add `edition2021` where necessary.
- Add necessary hidden code.
`mdbook test` isn't run on CI! It should be.

Plus some other CI improvements, based on the equivalent file at
`github.com/nnethercote/perf-book/`:
- Run actions on pull requests, to allow tests to run before merging.
- Add some missing names for steps.
- Update `actions/checkout` from v2 to v3.
this is also seen in the recent stabilization PR attempt: rust-lang/rust#122808 and rust playground confirms it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet