Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unescaped quotes breaking zk json output #403

Closed
wants to merge 7 commits into from
Closed

fix: unescaped quotes breaking zk json output #403

wants to merge 7 commits into from

Commits on Apr 3, 2024

  1. fix: works, but with caveat of old tests breaking. 

    It would seem that the old tesh test is not taking into account note
titles with `"` marks. Therefore, the failing test may be a sign of the
test needing to be updated, rather than this fix being void.
    @tjex
    tjex committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    be46e73 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Revert "fix: works, but with caveat of old tests breaking." 

    This reverts commit be46e73.
    @tjex
    tjex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e626a7d View commit details
    Browse the repository at this point in the history

  2. Added tesh case for zk graph -q --format json. 

    It should pass, but it fails because we're not
sanitizing double quotes in note titles properly.
    @tjex
    tjex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5bccc7c View commit details
    Browse the repository at this point in the history

  3. fix path and mod date placeholders in tesh

    @tjex
    tjex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fa2d4e6 View commit details
    Browse the repository at this point in the history

  4. fix: quotes in note titles breaking json output 

    Fix is however not idiomatic and is substandard,
therefore, consider as functional but a wip.
    @tjex
    tjex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0283dd4 View commit details
    Browse the repository at this point in the history

  5. filter more cli flag variations for json output

    @tjex
    tjex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    51e320b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into json-link-sanitize

    @tjex
    tjex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c0ca496 View commit details
    Browse the repository at this point in the history