Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phi-search-limit improvements #47

Open
wavexx opened this issue Sep 2, 2015 · 1 comment
Open

phi-search-limit improvements #47

wavexx opened this issue Sep 2, 2015 · 1 comment

Comments

@wavexx
Copy link

wavexx commented Sep 2, 2015

Somehow the handling of phi-search-limit is sub-par.

I often use incremental search to move the cursor (I find the behavior much more intuitive than ace-cursor or move-to-char), but if I search for a single space I reach the phi-search-limit immediately.

I think that phi-search-limit should be handled differently: if the limit is hit, just stop highlighting/counting (that is, create overlays for the first phi-search-limit matches and show 1/NaN in the search count or something similar), but still start the search.

This would allow to search for common strings in any circumstance, without really affecting performance.

@zk-phi
Copy link
Owner

zk-phi commented Sep 3, 2015

I don't have time to implement now, but I also think it's a necessary feature (#45).

(contributions are welcome!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants